Trailing punctuation included in tags

tracked

#1

Including a tag with punctuation immediately after it causes both the tag and the punctuation to be highlighted. For @example, in this sentence the highlighted portion would end up being: @example,

This cosmetic detail isn’t very significant and the expected value (without the punctuation) is added to the suggested list; however, clicking on the highlighted label (to do a search) populates the find box with both the tag and the punctuation, and this is unexpected behavior.

Steps to reproduce

Starting from scratch, what are the steps to make the bug happen? The fewer the steps, the better.

Add an item like: This is a @test. Be sure to include the punctuation.

Click on the highlighted link to perform a search.

Expected result

What do you expect to see after carrying out the steps above?

The word @test to be highlighted and clickable.

Actual result

Instead of the expected result, what happened?

The word and punctuation @test. are highlighted and clickable.

Environment

Which operating system are you using? Which browser are you using? If you’re using a desktop or mobile app, what’s the version number of Dynalist?

Chrome 55 on Windows 10 Anniversary. Sorry, not sure how to find out what version of Dynalist I’m using, but it appears to be up-to-date as of Friday, 2017-02-10 at 5pm EST.


Additional information

Anything else you think would help our investigation, like a screenshot or a log file? You can drag and drop screenshots to this box. For large amount of text, try putting them into something like Pastebin.

I’ve tested labels with a hash-sign at the beginning as well as an at-sign and with trailing commas and trailing periods at the end and the results seem to be the same. So things like

@test,
#test,
@test.
#test.

all seem to exhibit this behavior.


Additional comments


Exclude Tags Beginning with Numbers
Exclude Tags Beginning with Numbers
#2

This was tested on the web site, sorry for not specifying that.

On the Windows app, the functionality is the same as of Dynalist 1.0.19.


#3

Thanks for the report, @Chris_Allen!

This is partially expected, I think. You need a space in order to not include any trailing punctuation. That’s for the case where someone may want to include things like parenthesis to write fancy tags (e.g. @project(a) and @project(b)).

Our tag autocomplete will automatically inserts a space for you, FWIW.

That being said, it might be a good idea to exclude comma and period, since they are used so often. But then there are cases like @v1.0.9 where it might be useful.


#4

I just got bit by this, I have been making a list of tags inside a set or parentheses and I need to include a trailing space to make the tag not include the parentheses in it. It is not the end of the world, just a minor bother. I wonder just how many people include parentheses in their tags though?


#5

Agreed, probably my top daily annoyance in using the product. Definitely in the top 3. For example, I always have to stop and think whether I need to put a space after an @ name before ; ! / . ) instead of just writing naturally. I reported it here as well and there’re some good discussions there:

When in doubt, just use rules that work on other platforms, where you can’t have parentheses be considered as tag, instead of worrying about “fancy” tags. project(a) is a strange one, whereas “Don’t forget x (requested by @Bob)” is a normal thing to write.