Multi language spell checking

I80286 · December 15, 2019, 3:31pm

Hello dynalist team.

I’m not a native English speaker, but I do a lot of stuff with it.
I also native in 2 other languages that I use on daily basis.

Currently I use English spell check but it’d be very useful if it could do few of them (ex. like slack does that, it automatically understand which language you type)

It might be a case that that people that use dynalist live in the countries where they also use native language to own stuff and English for communication with people in other countries.
For example if you are developer you might work with people around the world but writing down things in English make a lot of sense if you going to share it later. But in other hand stuff they do for themselves or for own projects, people might do in the native lang.

Having ability to have multilang support might help a lot for this cases.

Erica · December 15, 2019, 6:57pm

I believe in the desktop app you can set which language you want the spellchecker to check, given your OS supports that language.

I’m not sure how Slack does it, are they spellchecking two languages mixed in the same message? Or do they detect the language on a per message basis?

I80286 · December 17, 2019, 12:49pm

Hi @Erica They used to detect word language somehow per word (but it broken now with their last “WYSYWIG” updated.
But still chrome know how to do it properly.
Maybe you can take look on https://github.com/electron/electron/pull/20692
Looks like Electron 8 has built in spell check that should work like same as built in chrome.

Erica · December 17, 2019, 9:30pm

@Shida: could you please take a look at this?

I believe we’re currently using a spellchecker plugin for Electron.

Shida · December 17, 2019, 10:03pm

I see what you mean! I believe our current spellchecker doesn’t have the capability to support multiple languages at the same time, but the electron built in spellchecker looks very promising!

I wish they have done this earlier as it was a pain to even get the current spellchecker working, but hopefully once it’s released we can begin migrating!

I80286 · December 17, 2019, 10:25pm

@Shida It’s going for stable at 2020-02-04. I can notify you once it’s released

Shida · December 17, 2019, 10:26pm

Thank you!

Braun_Shedd · December 31, 2019, 5:07pm

An alternative to this might be to allow setting the language on a per-document basis, which would allow using the current spellchecker plugin for Electron. Perhaps the ideal location would be to add a setting in the right-click dropdown menu when selecting a document in the ‘My Files’ tab.

Currently getting around this by changing the app-level spell checker when I need to edit / proofread documents in Spanish or Mandarin, which is workable (but not ideal )

I80286 · February 11, 2020, 2:08am

@Shida Just a friendly reminder) ElectronJs 8 already in current stable

Shida · February 11, 2020, 7:00am

Yup was looking at it a few days ago. Will be seeing how we can update to it soon.

Shida · February 20, 2020, 8:07pm

Just to update on this: there seems to be some serious/breaking bugs with Electron 8.0.0 and 8.0.1 right now so we’re going to at least wait until they’re ironed out in later patches.

MonkeyMonster · March 17, 2020, 9:41am

One more vote for multi (or at least 2) language spell checking.
I’d guess that most non-English speakers (like me) write in 2 languages…

By the way, how does one “vote” up a feature request?

Philipp · March 17, 2020, 12:57pm

Normaly there are Trello cards for this on the Dynalist-Roadmap. But multi language spell checking is still missing.

Is it possible to add it @Erica ? I want to vote as well.

Erica · April 3, 2020, 3:51am

We usually add features that are (1) larger and (2) we’re unsure if we’re going to implement.

We’re going to upgrade to Electron 8.0 sooner or later, and this is a pretty small thing compared to the other things on the board.

On the forum you can do that by liking the thread.

I80286 · May 14, 2020, 9:48pm

@Shida Hey! Just a friendly reminder.

Quite long time passed after Electron 8 release. Should stable now!

Is that any chance you could check it again please?

Shida · May 14, 2020, 10:58pm

I’ve tinkered with it a little bit. It’s mostly undocumented but I managed to get something working.
Right now I have an issue filed for a broken functionality but the electron team has largely ignored it. I’m guessing it’s not a critical issue to be resolved for them so it’s not getting on the priority list.

github.com/electron/electron

Renderer Node fs API stops working on page reload when allowRendererProcessReuse is true

opened 09:19AM - 10 Feb 20 UTC

closed 04:19PM - 13 Oct 20 UTC

lishid

bug

platform/all 9-x-y 10-x-y 11-x-y

### Preflight Checklist * [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project. * [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to. * [x] I have searched the issue tracker for an issue that matches the one I want to file, without success. ### Issue Details * **Electron Version:** * 8.0.0 * **Operating System:** * Windows 10 (1809) * **Last Known Working Electron version:** * Unknown When setting `app.allowRendererProcessReuse = true` and after reloading the renderer (`Ctrl+R` in developer console), Node `fs` APIs would randomly stop working. Specifically, the callbacks are never called, or if you're using `fs.promises`, the promises are never resolved. An interesting observation is: when you reload again, for a brief moment before the page is refreshed, the previous `fs` calls are magically unblocked. This can be observed by `console.log` lines suddenly printing the moment you hit `Ctrl+R` which disappears quickly as the whole page reloads. Possibly related: https://github.com/electron/electron/issues/19554 This issue sounds like the opposite of what's happening here. Also note: issue does not present itself when `app.allowRendererProcessReuse = false` ### Expected Behavior From the repro steps, expecting to see local files printed in the console: ``` ... renderer.js:8 Reading file main.js renderer.js:8 Reading file package-lock.json renderer.js:8 Reading file package.json renderer.js:8 Reading file preload.js renderer.js:8 Reading file README.md renderer.js:8 Reading file renderer.js renderer.js:14 done ``` ### Actual Behavior List is printed the first time the app loads. Hit Ctrl+R and observe only a few lines printed, or none at all. Hit Ctrl+R again and observe more lines printed for a split second before renderer reloads. ### To Reproduce Clone https://github.com/electron/electron-quick-start rendereer.js ``` (async () => { const fs = require('fs').promises; for (let i = 0; i < 10; i++) { let list = await fs.readdir('.', {withFileTypes: true}); for (let file of list) { if (file.isFile()) { console.log('Reading file', file.name); await fs.readFile(file.name, 'utf-8'); } } } console.log('done'); })(); ``` main.js ``` const {app, BrowserWindow} = require('electron'); function createWindow() { const win = new BrowserWindow({ width: 800, height: 600, webPreferences: { nodeIntegration: true } }); win.loadFile('index.html'); win.webContents.openDevTools(); } app.whenReady().then(createWindow); app.allowRendererProcessReuse = true; app.on('window-all-closed', () => { if (process.platform !== 'darwin') { app.quit(); } }); app.on('activate', () => { if (BrowserWindow.getAllWindows().length === 0) { createWindow(); } }); ``` ### Screenshots First boot: ![image](https://user-images.githubusercontent.com/609710/74136094-80cb5c00-4bbb-11ea-92fd-c49b87b3a9f3.png) On reload: ![image](https://user-images.githubusercontent.com/609710/74136317-cd169c00-4bbb-11ea-8e81-caf0e967bbd9.png) ### Additional Information

Meanwhile I’ll try to figure out how to update the settings UI to support this change later.

Sorry again it’s taking so long!

I80286 · May 14, 2020, 11:34pm

@Shida Thanks for update!

iron77 · September 4, 2022, 4:38pm

I just tried to enable spell-checker on my Windows/Dynalist app. It successfully works in english, but I see no way in Settings to change it to any other language. I’m not talking about “multi-language at once” functionality - I’m OK even with just one language at a time. Based on discussions on these forums I was under impression that it was previously possible. Where should I be able to find this setting?