Completing zoomed in item doesn't navigate to parent

closed

#1

Steps to reproduce

  • Have setting on to Hide “checked” items (i.e., completed)
  • Zoom into parent item, with children or otherwise.
  • Complete item by pressing Cmd-Enter
  • Observe it’s still displayed, crossed out
  • Navigate to parent, item is still displayed, despite the setting

Expected result

  • Similar to Workflowy, I expect to be navigated to the parent item automatically when I’m zoomed into a child and I complete that item
  • But even if I have to manually navigate out for some reason, I expect to have the item not displayed anymore when you navigate back to the completed item’s parent

Actual result

  • Stay in crossed out item, pointlessly
  • See crossed out item in parent, even though it should be hidden

Environment

macOS Chrome Version 62.0.3202.62 (Official Build) (64-bit)


Additional comments

If the reason is to allow the user to accidentally undo the item completion, that can always be done with Cmd-Z instead. The much more common use case is completing items you actually want to complete.


Expected behavior when complete zoomed in item
Advanced option to zoom out after completing current root item
#2

The checked item not being hidden after zooming out is indeed a bug, will fix as soon as we can!

I don’t see the other thing (not automatically navigating to parent after current root is checked) as a bug though. I know you’re probably coming from years of using WorkFlowy, but not everything that WorkFlowy has but Dynalist doesn’t is a bug… :grimacing:

This is pretty similar to just indent (item goes to bottom) vs indent in place (item stays in place), some people want the latter behavior, but it has some added assumptions we don’t want to make. In this case, we don’t assume the user wants to navigate back to the parent. Maybe he’s still looking at the content, and all he wants to do is checking something. I don’t see good reason to navigate for him, sorry.

The best we can do is similar to how indentation in place is handled – an extra option is added, and those who want the assumption to be made can check that.

I hope that’s understandable!


#3

If auto-zooming out after completion is added as an option, I would certainly welcome that. That would satisfy my case, and make the product more flexible. Although you obviously want to be careful making too many things configurable, as it’s going to hurt the maintainability of the product in the long-term.

But as far as “maybe he’s still looking at the content”, like I argued above, I think the standard behavior should satisfy the typical use case, not the 1% one. Usually when you mark something is done, it’s because it’s done, and you’re done with it. If you want to look at it some more, you an always undo the completion for a second, then re-do it. And this is especially true with the hide checked option on. If you want to look at checked items, wouldn’t that option be set to Show?

I don’t think you should go with just my opinion on this of course. Do we have polls as an option here? But my bet is that if you asked, “Do you show completed items to stay on screen when they’re set to be hidden?”, most would say no.


#4

Yes, there’s a poll section and anyone can post polls: http://talk.dynalist.io/c/polls


#5

@Erica, great idea. I created the poll: Expected behavior when complete zoomed in item

I’m a big fan of http://talk.dynalist.io/, btw, this is a great community platform.


#6

Thanks! The forum just had its first anniversary. Discourse has worked nicely for discussions and polls.


#7

Latest blog post says:

[UI/minor] Fixed checked items not becoming hidden after checking the current root item and zooming out.

I refreshed the content page, but I’m still seeing the same behavior. I check the parent item, zoom out, checked off item is still visible in the list.

Btw, some further behavior and possible another bug:

  • If I toggle Show / Hide to Show, then Hide again, the parent item correctly disappears
  • If I then hit Cmd-Z to undo, the parent item comes back, but its children are not visible at all, even though they were never checked off, only the parent item. This is true even if I zoom into that parent item.
  • If I toggle Show / Hide to Show, then Hide again, the children reappear

Please let me know if you something like a repro video to show this, but hopefully that’s clear.


#8

Sorry, that was a mistake, and I’ve corrected the blog post.

It will be in production before next Monday though.


#9

It should be fixed in the web app now, please confirm @Alex_Pasternak?


#10

The original bug seems to be better, and the parent disappears when you zoom out.

However, there is still the strange behavior I referenced where the children items appear/disappear depending on Show/Hide checkbox state when zoomed into the completed parent item, even though they’re not themselves completed. I referenced this in more detail in the comment above. Once again, lmk if you’d rather have a separate bug report on this, but it seems pretty connected.


#11

Yeah I’d really appreciate that. We try to resolve bug as it was reported, and I believe that’s the case for this bug, with its reproduction steps and expected/actual results. Separating them is better for communication and morale :slight_smile:


#12

Any further to fixing this behavior, or making it configurable? Don’t you think it’s strange that this is an exception to the user-selected filter? My setting literally says Hide checked items, and yet I’m able to see this checked item.

It’s like the user said “I only want to see red items” and then changes one to a green. DL here says “I heard you, but this one used to be red, so you probably still want to see it?” Nope. It’s completed, I want it out of my sight right away.


#13

Same thing when you set notes to hidden, but you will still see it when you start editing the note. I think the deal-breaker for us is that we do not want the zoom out behavior. So if we hide the root item, the page will be a blank page…

I’d like to think it’s universally considered strange, but from the poll it looks like it’s debatable. It’s not like the majority of users think the current behavior is completely normal either, otherwise the poll result would be more like 90% to 10% rather than 50% to 50%, so maybe we can add (yet) another advanced option for this.


#14

Hi @Alex_Pasternak,

Doing a bug clean-up right now, do you mind if I close this? I’ve move it to be a feature request.


#15

Thanks for checking, sure. Since the current behavior is by design, a feature request to control it does seem more appropriate.