Link in Search result is broken

fixed

#1

Steps to reproduce

Create a link
Search for the link

Expected result

Get only the part highlighted without breaking the link - the entire link should be clickable, not only until the highlighted text.

Actual result

Get link highlighted, without destroying the rest of the link

Environment

Mac OS X / Chrome 59 / Latest Dynalist


Additional information


#2

This is a known bug that’s non-trivial to fix.

cc @Shida, got quite a few reports about this recently.


#3

No problem! This is no big deal :slight_smile:
From what I have analyzed, the formatter deals with the DOM on a low level. Manual insertions instead of nesting the highlighted text within the formatted string. Which looks a lot more complex than it should be. You should consider switching to a custom templating language, instead of manually inserting DOM Nodes one after another.

Best,
Martin


#4

Came here to report this one.

This bug is super annoying for me, as I have a collection of project info in Dynalist with a lot of links, and all the links are broken when I search for them.

Took me a while to figure out it was a rendering bug rather than corrupted links in the data


#5

@Nick_Clarke Thanks for the input!

@Shida: How hard is it to fix this?


#6

Will take a bit of time but I think it’s doable


#7

Update: should be fixed in the latest version on web.

@Martin_Muzatko @Nick_Clarke could you guys confirm it works for your use cases?


#8

Works.

Search still works in anchor text (the words used to link) as well as in the URL itself. Depending on how you look at it that may or may not be wanted :slight_smile:


#9

Awesome! Works flawlessly :slight_smile:


#10

Fixed! Thanks heaps for this :slight_smile: