Have lost ability to cancel filter using Esc key

fixed

#1

Steps to reproduce

  • Start a search with Cmd-F, type in query, Enter to filter items
  • Hit Esc to clear the filter and return to full item list, but doesn’t happen

Expected / Actual result

I expect to clear filter with Esc, but instead it toggles whether the currently highlighted item is shown in MD or fully rendered. But even if the focus is in the filter textbox, Esc still does nothing.

Environment

Firefox 59.0.1 macOS 10.13
Also occurs in desktop app 1.0.3


Additional Comments

I feel like this must’ve been broken by recent changes. Is it a regression from how keys are handled by filter textbox, or something else?


Search mode is awkward to get back out from
#2

New feature, using Esc to deactivate the current item, is conflicting with this old feature.


#3

Oh, that’s explanation then. Please tell me there’s a preference for this? It’s driving me crazy. I filter all the time, but couldn’t care less about escaping current item’s edit focus.


#4

Sorry, it’s unexpected and will be fixed very soon. Sorry about that!


#5

@Alex_Pasternak @Alan: This should be fixed in the latest versions (please refresh/reload the app to update), could you please confirm when you have time? Thanks in advance!


#6

Well it partially works, from my perspective. Esc cancels filter if your focus is in the filter textbox, but it still just toggles edit status of the item if you’ve clicked out and are on an item. Typically after you look for some items, you’re not going to stay in the filter textbox, unless you were just looking something up.

The typical filter workflow for me is to filter, do something with the item, and close the filter. For this, Esc is still not working correctly. I was hoping the fix logic would be: Esc -> Am I in a filter? -> If yes, cancel it -> Otherwise, toggle item edit render. Was that deliberately not done?

For items that don’t even have any MD markup, plain text ones, it looks particularly bad. Your cursor is there on the item, a filter is in effect, you keep mashing Esc and nothing even appears to happen.


#7

I think the behavior of Esc regarding search has been restored, but it’s slightly modified to accommodate a new feature. That is, when you’re focusing on the search box, search is canceled. If you’re focusing on some other item, you’ll need to first Ctrl+F to go the search box and then Esc again.

What about the opposite: “Esc -> am I editing an item? -> If yes, blur it -> Otherwise, if searching, cancel search”.

It seems more intuitive this way. When your cursor is on an item, Esc seems like it should blur that part first.


#8

May I propose Esc (unfocus) Esc (cancel search) to get out of search if you are focused on an item?


#9

Yeah, that’s what I proposed above too:


#10

@Erica, I agree, that is better, and more context-specific that way. I would 100% support this, and consider this the full resolution for the current behavior.


#11

Agreed, I’d like that behavior too.


#12

@Craig_Oliver @Alex_Pasternak: got it! Will update here when it’s done.


#13

@Alex_Pasternak @Craig_Oliver: This should be fixed in the latest versions (please refresh/reload the app to update), could you please confirm when you have time? Thanks in advance!

P.S. Web only for now, coming to desktop app soon!


#14

Yes, it works for me! Thanks very much for making this change!


#15

Yes, much better now, it seems, thanks!

I hope you get cycles to work on further Web bugs soon. I see a lot of weekly fixes on iOS, but Web should be the primary platform, and there’re a lot of bugs (or perhaps “unexpected behaviors” depending on where you’re coming from) I still run into on a daily basis.


#16

If you’ve filed those bugs, we should get to it eventually.

The mobile apps are receiving a lot of attention recently because it’s too lacking. Not sure how much you use them, some people depend on them on a daily basis.

Personally I don’t use my phone that much either, but we think at this point we should put a bit more time into the mobile apps, since you can’t even select multiple items or upload files on them. It’s not a matter of unexpected behaviors, but rather the absence of certain functionalities.

I hope that’s understandable!